mustafasrepo commented on code in PR #8006:
URL: https://github.com/apache/arrow-datafusion/pull/8006#discussion_r1379662628


##########
datafusion/core/src/physical_optimizer/sort_pushdown.rs:
##########
@@ -298,34 +302,34 @@ fn pushdown_requirement_to_children(
 /// If the the parent requirements are more specific, push down the parent 
requirements
 /// If they are not compatible, need to add Sort.
 fn determine_children_requirement(
-    parent_required: Option<&[PhysicalSortRequirement]>,
-    request_child: Option<&[PhysicalSortRequirement]>,
+    parent_required: LexRequirementRef,

Review Comment:
   I opened the issue 
[#8026](https://github.com/apache/arrow-datafusion/issues/8026) to track this 
feature 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to