mustafasrepo commented on code in PR #8006:
URL: https://github.com/apache/arrow-datafusion/pull/8006#discussion_r1379670001
##########
datafusion/physical-expr/src/physical_expr.rs:
##########
@@ -226,17 +228,78 @@ pub fn physical_exprs_contains(
.any(|physical_expr| physical_expr.eq(expr))
}
+/// Checks whether the given slices have any common entries.
+pub fn have_common_entries(
+ lhs: &[Arc<dyn PhysicalExpr>],
+ rhs: &[Arc<dyn PhysicalExpr>],
+) -> bool {
+ lhs.iter().any(|expr| physical_exprs_contains(rhs, expr))
+}
+
+/// Checks whether the given physical expression slices are equal.
+pub fn physical_exprs_equal(
+ lhs: &[Arc<dyn PhysicalExpr>],
+ rhs: &[Arc<dyn PhysicalExpr>],
+) -> bool {
+ lhs.len() == rhs.len() && izip!(lhs, rhs).all(|(lhs, rhs)| lhs.eq(rhs))
+}
+
+/// Checks whether the given physical expression slices are equal in the sense
+/// of bags (multi-sets), disregarding their orderings.
+pub fn physical_exprs_bag_equal(
+ lhs: &[Arc<dyn PhysicalExpr>],
+ rhs: &[Arc<dyn PhysicalExpr>],
+) -> bool {
+ // TODO: Once we can use `HashMap`s with `Arc<dyn PhysicalExpr>`, this
+ // function should use a `HashMap` to reduce computational
complexity.
+ if lhs.len() == rhs.len() {
+ let mut rhs_vec = rhs.to_vec();
+ for expr in lhs {
+ if let Some(idx) = rhs_vec.iter().position(|e| expr.eq(e)) {
+ rhs_vec.swap_remove(idx);
+ } else {
+ return false;
+ }
+ }
+ true
+ } else {
+ false
+ }
+}
+
+/// This utility function removes duplicates from the given `exprs` vector.
+/// Note that this function does not necessarily preserve its input ordering.
+pub fn deduplicate_physical_exprs(exprs: &mut Vec<Arc<dyn PhysicalExpr>>) {
+ // TODO: Once we can use `HashSet`s with `Arc<dyn PhysicalExpr>`, this
Review Comment:
I have opened the issue
[#8027](https://github.com/apache/arrow-datafusion/issues/8027) to track this
support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
