alamb commented on code in PR #8036:
URL: https://github.com/apache/arrow-datafusion/pull/8036#discussion_r1380656322
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -35,39 +35,33 @@ use datafusion_physical_expr::expressions::{col, Sum};
use datafusion_physical_expr::{AggregateExpr, PhysicalSortExpr};
use test_utils::add_empty_batches;
-#[cfg(test)]
-#[allow(clippy::items_after_test_module)]
-mod tests {
- use super::*;
-
- #[tokio::test(flavor = "multi_thread", worker_threads = 8)]
- async fn aggregate_test() {
- let test_cases = vec![
- vec!["a"],
- vec!["b", "a"],
- vec!["c", "a"],
- vec!["c", "b", "a"],
- vec!["d", "a"],
- vec!["d", "b", "a"],
- vec!["d", "c", "a"],
- vec!["d", "c", "b", "a"],
- ];
- let n = 300;
- let distincts = vec![10, 20];
- for distinct in distincts {
- let mut handles = Vec::new();
- for i in 0..n {
- let test_idx = i % test_cases.len();
- let group_by_columns = test_cases[test_idx].clone();
- let job = tokio::spawn(run_aggregate_test(
- make_staggered_batches::<true>(1000, distinct, i as u64),
- group_by_columns,
- ));
- handles.push(job);
- }
- for job in handles {
- job.await.unwrap();
- }
+#[tokio::test(flavor = "multi_thread", worker_threads = 8)]
Review Comment:
Reviewing this with whitespace blind diff shows what is going on pretty
clearly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
