waynexia commented on code in PR #8036:
URL: https://github.com/apache/arrow-datafusion/pull/8036#discussion_r1381117383
##########
datafusion/core/src/datasource/file_format/arrow.rs:
##########
@@ -105,7 +105,7 @@ impl FileFormat for ArrowFormat {
const ARROW_MAGIC: [u8; 6] = [b'A', b'R', b'R', b'O', b'W', b'1'];
const CONTINUATION_MARKER: [u8; 4] = [0xff; 4];
-/// Custom implementation of inferring schema. Should eventually be moved
upstream to arrow-rs.
+/// Custom implementation of inferring schema. Should eventually be moved
upstream to arrow-rs.
/// See https://github.com/apache/arrow-rs/issues/5021
Review Comment:
```suggestion
/// See <https://github.com/apache/arrow-rs/issues/5021>
```
Copied from `cargo doc`'s output. First heard of [this
lint](https://github.com/rust-lang/rust/issues/77501) to me 🫣
##########
datafusion/core/src/datasource/file_format/arrow.rs:
##########
@@ -105,7 +105,7 @@ impl FileFormat for ArrowFormat {
const ARROW_MAGIC: [u8; 6] = [b'A', b'R', b'R', b'O', b'W', b'1'];
const CONTINUATION_MARKER: [u8; 4] = [0xff; 4];
-/// Custom implementation of inferring schema. Should eventually be moved
upstream to arrow-rs.
+/// Custom implementation of inferring schema. Should eventually be moved
upstream to arrow-rs.
/// See https://github.com/apache/arrow-rs/issues/5021
Review Comment:
```suggestion
/// See <https://github.com/apache/arrow-rs/issues/5021>
```
Copied from `cargo doc`'s output. First heard of [this
lint](https://github.com/rust-lang/rust/issues/77501) to me 🫣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
