junjunjd commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1381195593
##########
datafusion/common/src/scalar.rs:
##########
@@ -1562,7 +1597,11 @@ impl ScalarValue {
DataType::UInt16 =>
dict_from_values::<UInt16Type>(values)?,
DataType::UInt32 =>
dict_from_values::<UInt32Type>(values)?,
DataType::UInt64 =>
dict_from_values::<UInt64Type>(values)?,
- _ => unreachable!("Invalid dictionary keys type: {:?}",
key_type),
Review Comment:
I agree it makes more sense to keep `unreachable!` here to align with how
`arrow-rs` deals with illegal dictionary key types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
