junjunjd commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1381209821
##########
datafusion/common/src/scalar.rs:
##########
@@ -2259,71 +2316,63 @@ impl ScalarValue {
ScalarValue::List(arr)
}
- DataType::Date32 => {
- typed_cast!(array, index, Date32Array, Date32)
- }
- DataType::Date64 => {
- typed_cast!(array, index, Date64Array, Date64)
- }
+ DataType::Date32 => typed_cast!(array, index, Date32Array,
Date32)?,
+ DataType::Date64 => typed_cast!(array, index, Date64Array,
Date64)?,
DataType::Time32(TimeUnit::Second) => {
- typed_cast!(array, index, Time32SecondArray, Time32Second)
+ typed_cast!(array, index, Time32SecondArray, Time32Second)?
}
DataType::Time32(TimeUnit::Millisecond) => {
- typed_cast!(array, index, Time32MillisecondArray,
Time32Millisecond)
+ typed_cast!(array, index, Time32MillisecondArray,
Time32Millisecond)?
}
DataType::Time64(TimeUnit::Microsecond) => {
- typed_cast!(array, index, Time64MicrosecondArray,
Time64Microsecond)
+ typed_cast!(array, index, Time64MicrosecondArray,
Time64Microsecond)?
}
DataType::Time64(TimeUnit::Nanosecond) => {
- typed_cast!(array, index, Time64NanosecondArray,
Time64Nanosecond)
- }
- DataType::Timestamp(TimeUnit::Second, tz_opt) => {
- typed_cast_tz!(
- array,
- index,
- TimestampSecondArray,
- TimestampSecond,
- tz_opt
- )
- }
- DataType::Timestamp(TimeUnit::Millisecond, tz_opt) => {
- typed_cast_tz!(
- array,
- index,
- TimestampMillisecondArray,
- TimestampMillisecond,
- tz_opt
- )
- }
- DataType::Timestamp(TimeUnit::Microsecond, tz_opt) => {
- typed_cast_tz!(
- array,
- index,
- TimestampMicrosecondArray,
- TimestampMicrosecond,
- tz_opt
- )
- }
- DataType::Timestamp(TimeUnit::Nanosecond, tz_opt) => {
- typed_cast_tz!(
- array,
- index,
- TimestampNanosecondArray,
- TimestampNanosecond,
- tz_opt
- )
+ typed_cast!(array, index, Time64NanosecondArray,
Time64Nanosecond)?
}
+ DataType::Timestamp(TimeUnit::Second, tz_opt) => typed_cast_tz!(
+ array,
+ index,
+ TimestampSecondArray,
+ TimestampSecond,
+ tz_opt
+ )?,
+ DataType::Timestamp(TimeUnit::Millisecond, tz_opt) =>
typed_cast_tz!(
+ array,
+ index,
+ TimestampMillisecondArray,
+ TimestampMillisecond,
+ tz_opt
+ )?,
+ DataType::Timestamp(TimeUnit::Microsecond, tz_opt) =>
typed_cast_tz!(
+ array,
+ index,
+ TimestampMicrosecondArray,
+ TimestampMicrosecond,
+ tz_opt
+ )?,
+ DataType::Timestamp(TimeUnit::Nanosecond, tz_opt) =>
typed_cast_tz!(
+ array,
+ index,
+ TimestampNanosecondArray,
+ TimestampNanosecond,
+ tz_opt
+ )?,
DataType::Dictionary(key_type, _) => {
let (values_array, values_index) = match key_type.as_ref() {
- DataType::Int8 => get_dict_value::<Int8Type>(array, index),
- DataType::Int16 => get_dict_value::<Int16Type>(array,
index),
- DataType::Int32 => get_dict_value::<Int32Type>(array,
index),
- DataType::Int64 => get_dict_value::<Int64Type>(array,
index),
- DataType::UInt8 => get_dict_value::<UInt8Type>(array,
index),
- DataType::UInt16 => get_dict_value::<UInt16Type>(array,
index),
- DataType::UInt32 => get_dict_value::<UInt32Type>(array,
index),
- DataType::UInt64 => get_dict_value::<UInt64Type>(array,
index),
- _ => unreachable!("Invalid dictionary keys type: {:?}",
key_type),
Review Comment:
See previous
[comment](https://github.com/apache/arrow-datafusion/pull/7901/files#r1381195593).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
