korowa commented on PR #8020: URL: https://github.com/apache/arrow-datafusion/pull/8020#issuecomment-1792949167
Thank you @alamb , but I don't think this PR worth benchmarking it -- after running current unit tests with different batch sizes, I've found that arguments for `adjust_indices_by_join_type` not really correct in this version + it works incorrect with join filters, so I suppose I need a bit more time to figure it out 😞 And yes, in this context, your suggestion about placing state management logic into separate `JoinOutputBuilder` struct is definitely worthwhile -- I'll look for an options of separating state from other join internals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
