alamb commented on PR #8020: URL: https://github.com/apache/arrow-datafusion/pull/8020#issuecomment-1796383204
Here are my benchmark results. My conclusion is that there is no significant performance change (the faster/slower is within the realm of noise). I will try running at a larger scale to see if anything shows up ``` -------------------- Benchmark tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ hash_join_batch_size ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 928.44ms │ 930.39ms │ no change │ │ QQuery 2 │ 210.54ms │ 222.96ms │ 1.06x slower │ │ QQuery 3 │ 454.08ms │ 463.21ms │ no change │ │ QQuery 4 │ 248.99ms │ 280.77ms │ 1.13x slower │ │ QQuery 5 │ 589.44ms │ 581.81ms │ no change │ │ QQuery 6 │ 219.45ms │ 223.18ms │ no change │ │ QQuery 7 │ 925.05ms │ 1063.70ms │ 1.15x slower │ │ QQuery 8 │ 675.09ms │ 717.43ms │ 1.06x slower │ │ QQuery 9 │ 1052.59ms │ 1050.42ms │ no change │ │ QQuery 10 │ 712.75ms │ 688.61ms │ no change │ │ QQuery 11 │ 212.84ms │ 200.64ms │ +1.06x faster │ │ QQuery 12 │ 362.82ms │ 359.72ms │ no change │ │ QQuery 13 │ 560.56ms │ 580.54ms │ no change │ │ QQuery 14 │ 322.74ms │ 305.90ms │ +1.06x faster │ │ QQuery 15 │ 232.62ms │ 235.21ms │ no change │ │ QQuery 16 │ 184.60ms │ 188.35ms │ no change │ │ QQuery 17 │ 1218.95ms │ 1166.47ms │ no change │ │ QQuery 18 │ 1741.70ms │ 1742.98ms │ no change │ │ QQuery 19 │ 566.74ms │ 551.15ms │ no change │ │ QQuery 20 │ 482.46ms │ 456.34ms │ +1.06x faster │ │ QQuery 21 │ 1388.65ms │ 1408.79ms │ no change │ │ QQuery 22 │ 171.23ms │ 165.01ms │ no change │ └──────────────┴───────────┴──────────────────────┴───────────────┘ -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ hash_join_batch_size ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 588.55ms │ 574.48ms │ no change │ │ QQuery 2 │ 154.73ms │ 163.05ms │ 1.05x slower │ │ QQuery 3 │ 152.65ms │ 154.83ms │ no change │ │ QQuery 4 │ 109.42ms │ 110.63ms │ no change │ │ QQuery 5 │ 379.86ms │ 391.93ms │ no change │ │ QQuery 6 │ 39.26ms │ 39.47ms │ no change │ │ QQuery 7 │ 885.93ms │ 898.37ms │ no change │ │ QQuery 8 │ 277.20ms │ 279.22ms │ no change │ │ QQuery 9 │ 565.02ms │ 548.77ms │ no change │ │ QQuery 10 │ 311.39ms │ 304.02ms │ no change │ │ QQuery 11 │ 172.35ms │ 172.79ms │ no change │ │ QQuery 12 │ 144.86ms │ 152.07ms │ no change │ │ QQuery 13 │ 241.93ms │ 253.64ms │ no change │ │ QQuery 14 │ 48.83ms │ 45.23ms │ +1.08x faster │ │ QQuery 15 │ 45.07ms │ 46.21ms │ no change │ │ QQuery 16 │ 150.89ms │ 160.37ms │ 1.06x slower │ │ QQuery 17 │ 751.06ms │ 763.63ms │ no change │ │ QQuery 18 │ 1349.89ms │ 1498.83ms │ 1.11x slower │ │ QQuery 19 │ 144.74ms │ 150.76ms │ no change │ │ QQuery 20 │ 305.43ms │ 312.09ms │ no change │ │ QQuery 21 │ 1026.75ms │ 1060.09ms │ no change │ │ QQuery 22 │ 90.80ms │ 87.23ms │ no change │ └──────────────┴───────────┴──────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
