tschaub commented on PR #38581:
URL: https://github.com/apache/arrow/pull/38581#issuecomment-1793410455

   Thank you for looking into this and finding the issue, @mapleFU.
   
   My assumption was that the last argument to the 
`pqarrow.NewArrowColumnWriter` function was the Arrow column index instead of 
the Parquet column index (or logical instead of physical, not sure which terms 
to use).  And the current tests support this assumption.
   
   Maybe the question for @zeroshade is whether the tests are correct (last arg 
is logical/Arrow col index) or the source is correct (last arg is 
physical/Parquet col index).
   
   This has been a source of uncertainty for me when `col` is used in the 
documentation.  I look forward to better understanding which interpretation is 
meant (or is `field` a better term to differentiate?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to