zeroshade commented on PR #38581: URL: https://github.com/apache/arrow/pull/38581#issuecomment-1809391483
Hmm, originally the intent when i wrote that was essentially sort of a "destination column index" type thing, which is why it referred to the physical parquet index to start at. It also simplified the code in general. Typically most people would likely not be creating an ArrowColumnWriter directly but rather would be just using the `pqarrow.Writer` itself and writing the records as is (with the ArrowColumnWriter being used internally in most situations). Personally, I prefer the usage of the last arg being the physical parquet column to start writing at, which seems more intuitive to me in general if you look at it in terms of being a "destination to start writing at" which makes the ArrowColumnWriter more versatile and able to be used regardless of what the *arrow* schema was (at least in my mind). What do you think @mapleFU of @tschaub's comments? I'm fine with being outvoted on this if others find it more intuitive for it to be the opposite. You get to be a tie breaker :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
