alamb opened a new pull request, #8054: URL: https://github.com/apache/arrow-datafusion/pull/8054
## Which issue does this PR close? Follow on to https://github.com/apache/arrow-datafusion/pull/8050 from @jayzhan211 -- ## Rationale for this change The change in https://github.com/apache/arrow-datafusion/pull/8050 is a huge improvement, and while reviewing it I saw a few more things to improve: Null handing and avoiding some copies. I also wanted to try and help set some patterns for other array function rewrites that I think @jayzhan211 is planning ## What changes are included in this PR? 1. Add comments to `general_array` and change names of parameters and variables so it is easier (in my opinion) to follow the logic 2. Handles NULL values now ## Are these changes tested? 1. Covered by existing test 2. Added a new test for null values <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? No internal errors on nulls <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
