jayzhan211 commented on code in PR #8054:
URL: https://github.com/apache/arrow-datafusion/pull/8054#discussion_r1382690793


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -2763,6 +2789,52 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_array_replace_with_null() {
+        // ([3, 1, NULL, 3], 3,    4,    2)  => [4, 1, NULL, 4] NULL not 
matched
+        // ([3, 1, NULL, 3], NULL, 5,    2)  => [3, 1, NULL, 3]  NULL  not 
replaced (not eq)

Review Comment:
   I believe it's reasonable for arrow-rs to handle null comparisons



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to