2010YOUY01 commented on code in PR #8059:
URL: https://github.com/apache/arrow-datafusion/pull/8059#discussion_r1382773369
##########
datafusion/expr/src/signature.rs:
##########
@@ -82,31 +82,36 @@ pub enum Volatility {
/// ```
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub enum TypeSignature {
- /// arbitrary number of arguments of an common type out of a list of valid
types.
Review Comment:
I checked the current functions' signatures, `Variadic*` actually means
supports 1 or more arguments instead of "arbitrary number" for current
implementations, and use `supports_zero_arguments()` to determine whether 0 arg
case is allowed.
So the doc comment is updated for clarification:
`Variadic*` means support 1 or more args
`OneOf(Any(0), Variadic*)` means support 0 or more args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
