alamb commented on code in PR #8059:
URL: https://github.com/apache/arrow-datafusion/pull/8059#discussion_r1383170808
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -325,6 +325,10 @@ fn function_to_name() -> &'static
HashMap<BuiltinScalarFunction, &'static str> {
impl BuiltinScalarFunction {
/// an allowlist of functions to take zero arguments, so that they will
get special treatment
/// while executing.
+ #[deprecated(
+ since = "32.0.0",
+ note = "please use TypeSignature::supports_zero_argument instead"
+ )]
pub fn supports_zero_argument(&self) -> bool {
matches!(
Review Comment:
Can you also please change this method to call into
`self.type_signature().supports_zero_argument` so it is clear they are
equivalent and so the implementations don't drift out of sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
