vibhatha commented on code in PR #38423:
URL: https://github.com/apache/arrow/pull/38423#discussion_r1384386091
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowReader.java:
##########
@@ -243,6 +248,8 @@ protected void loadDictionary(ArrowDictionaryBatch
dictionaryBatch) {
}
return;
}
+ // TODO - If the super class is a file reader it may be good to throw an
exception here
+ // the dictionary failed to satisfy the spec (i.e. being a replacement
dictionary)
Review Comment:
It would be better if we could create an issue for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
