vibhatha commented on code in PR #38423:
URL: https://github.com/apache/arrow/pull/38423#discussion_r1384438762
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowFileWriter.java:
##########
@@ -130,14 +130,24 @@ protected void endInternal(WriteChannel out) throws
IOException {
protected void ensureDictionariesWritten(DictionaryProvider provider,
Set<Long> dictionaryIdsUsed)
throws IOException {
if (dictionariesWritten) {
+ for (long id : dictionaryIdsUsed) {
+ BaseDictionary dictionary = provider.lookup(id);
+ if (dictionary.getEncoding().isDelta()) {
+ writeDictionaryBatch(dictionary, false);
+ }
+ // TODO - It would be useful to throw an exception here if a
replacement dictionary was found
+ // with modifications. Replacements are not currently allowed in
files. For now, we just drop it
+ // and throw an exception in the BatchedDictionary and hope users use
that class.
+ }
Review Comment:
Shall we create an issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
