msirek commented on code in PR #8038:
URL: https://github.com/apache/arrow-datafusion/pull/8038#discussion_r1385245175
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -266,6 +266,12 @@ pub(crate) struct GroupedHashAggregateStream {
/// The spill state object
spill_state: SpillState,
+
+ /// Optional soft limit on the number of `group_values` in a batch
+ /// If the number of `group_values` in a single batch exceeds this value,
+ /// the `GroupedHashAggregateStream` operation immediately switches to
+ /// output mode and emits all groups.
+ group_values_soft_limit: Option<usize>,
Review Comment:
Thanks. I believe this is ready for a look. Please let me know if you think
I should break it down into smaller PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
