msirek commented on code in PR #8038:
URL: https://github.com/apache/arrow-datafusion/pull/8038#discussion_r1387163241
##########
datafusion/core/src/physical_optimizer/optimizer.rs:
##########
@@ -79,6 +80,8 @@ impl PhysicalOptimizer {
// repartitioning and local sorting steps to meet distribution and
ordering requirements.
// Therefore, it should run before EnforceDistribution and
EnforceSorting.
Arc::new(JoinSelection::new()),
+ // The LimitedDistinctAggregation rule should be applied before
the EnforceDistribution rule
Review Comment:
> I think adding the rationale for this limitation would be helpful. Your PR
description I think explains it pretty well:
Made the suggested change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
