korowa commented on PR #8020: URL: https://github.com/apache/arrow-datafusion/pull/8020#issuecomment-1799528230
@alamb @metesynnada thank you! I've addressed some comments, and, just to sum up, remaining ones (major ones) I'm going to work on: - completely retain SHJ logic -- been considering this option, but code duplication confused me a bit. However, if it's not a problem -- I'll revert all the changes regarding SHJ - maintaining original build side sort order (`order by probe.key, build.key` -- as it was before) -- going to check out an approach with modifying build-side collection & updating `JoinHashMap` - enum / more straightforward / readable state management -- going to look for more neat implementation (thanks for guidance!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
