niyue commented on code in PR #38632:
URL: https://github.com/apache/arrow/pull/38632#discussion_r1386757020
##########
cpp/src/gandiva/engine.cc:
##########
@@ -447,7 +447,11 @@ void Engine::AddGlobalMappingForFunc(const std::string&
name, llvm::Type* ret_ty
execution_engine_->addGlobalMapping(fn, function_ptr);
}
-void Engine::AddGlobalMappings() { ExportedFuncsRegistry::AddMappings(this); }
+arrow::Status Engine::AddGlobalMappings() {
+ ARROW_RETURN_NOT_OK(ExportedFuncsRegistry::AddMappings(this));
+ ExternalCInterfaceFunctions c_interface_funcs(function_registry_);
+ return c_interface_funcs.AddMappings(this);
Review Comment:
The external C interface functions are added and mapped to the JIT engine
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
