niyue commented on code in PR #38632:
URL: https://github.com/apache/arrow/pull/38632#discussion_r1386760417
##########
cpp/src/gandiva/engine.cc:
##########
@@ -147,7 +147,7 @@ Engine::Engine(const std::shared_ptr<Configuration>& conf,
Status Engine::Init() {
std::call_once(register_exported_funcs_flag, gandiva::RegisterExportedFuncs);
// Add mappings for global functions that can be accessed from LLVM/IR
module.
- AddGlobalMappings();
+ ARROW_RETURN_NOT_OK(AddGlobalMappings());
Review Comment:
For external C interface functions, they may cause some error when adding
mapping for them, so I change the `AddGlobalMappings` and
`ExportedFuncsBase::AddMappings` functions to return `arrow::Status` to
represent the result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
