alamb commented on code in PR #8055:
URL: https://github.com/apache/arrow-datafusion/pull/8055#discussion_r1386969674
##########
datafusion/physical-expr/src/aggregate/array_agg_distinct.rs:
##########
@@ -48,12 +50,14 @@ impl DistinctArrayAgg {
expr: Arc<dyn PhysicalExpr>,
name: impl Into<String>,
input_data_type: DataType,
+ is_expr_nullable: bool,
Review Comment:
should we perhaps update the docstrings here to explain `is_expr_nullable`
means if the input can have nulls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
