alamb commented on code in PR #8055:
URL: https://github.com/apache/arrow-datafusion/pull/8055#discussion_r1386974648
##########
datafusion/physical-expr/src/aggregate/array_agg.rs:
##########
@@ -37,6 +37,7 @@ pub struct ArrayAgg {
name: String,
input_data_type: DataType,
expr: Arc<dyn PhysicalExpr>,
+ is_expr_nullable: bool,
Review Comment:
What do you think about calling this just `nullable` ? it is a bit more
concise and aligns with the name used in `Field`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
