assignUser commented on code in PR #38534:
URL: https://github.com/apache/arrow/pull/38534#discussion_r1387466508
##########
r/tools/nixlibs.R:
##########
@@ -35,7 +35,9 @@ exit <- function(..., .status = 1) {
# checks the nightly repo for the latest nightly version X.Y.Z.100<dev>
-find_latest_nightly <- function(description_version) {
+find_latest_nightly <- function(description_version,
+ list_uri =
"https://nightlies.apache.org/arrow/r/src/contrib/PACKAGES";,
Review Comment:
oh yeah that makes more sense ^^
##########
r/tools/nixlibs.R:
##########
@@ -867,6 +887,8 @@ build_ok <- !env_is("LIBARROW_BUILD", "false")
# https://arrow.apache.org/docs/developers/cpp/building.html#offline-builds)
download_ok <- !test_mode && !env_is("TEST_OFFLINE_BUILD", "true")
+download_libarrow_ok <- download_ok && !env_is("LIBARROW_DOWNLOAD", "false")
Review Comment:
Why this addition? Would not `LIBARROW_BINARY=false` do the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
