paleolimbot commented on code in PR #38534:
URL: https://github.com/apache/arrow/pull/38534#discussion_r1387986814
##########
r/tools/nixlibs.R:
##########
@@ -867,6 +887,8 @@ build_ok <- !env_is("LIBARROW_BUILD", "false")
# https://arrow.apache.org/docs/developers/cpp/building.html#offline-builds)
download_ok <- !test_mode && !env_is("TEST_OFFLINE_BUILD", "true")
+download_libarrow_ok <- download_ok && !env_is("LIBARROW_DOWNLOAD", "false")
Review Comment:
I forget what exactly it caused to fail, but I think the idea is that
LIBARROW_BINARY controls whether or not static libs are attempted, sort of, and
LIBARROW_DOWNLOAD strictly controls whether or not an http request is issued to
get that binary. Mostly I just noticed that it was already set in the CI job (
https://github.com/apache/arrow/actions/runs/6801463295/job/18492381028?pr=38534#step:5:1094
) and it was somewhat complicated to figure out how to wire up LIBARROW_BINARY
because of the levels of abstraction on top of the R CI jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
