felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1388422772
##########
cpp/src/arrow/array/array_nested.h:
##########
@@ -105,6 +103,23 @@ class BaseListArray : public Array {
const offset_type* raw_value_offsets_ = NULLPTR;
};
+// ----------------------------------------------------------------------
+// ListArray / LargeListArray
+
+template <typename TYPE>
+class BaseListArray : public VarLengthListLikeArray<TYPE> {
+ public:
+ using TypeClass = TYPE;
+ using offset_type = typename TYPE::offset_type;
+
+ const TypeClass* list_type() const { return
this->var_length_list_like_type(); }
+
+ offset_type value_length(int64_t i) const final {
Review Comment:
Yes, unlocking inlining of the call. And all the other complicated scenarios
where the compiler is able to devirtualize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
