felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1388441202
##########
cpp/src/arrow/array/array_nested.h:
##########
@@ -181,7 +199,14 @@ class ARROW_EXPORT LargeListArray : public
BaseListArray<LargeListType> {
/// This function does the bare minimum of validation of the offsets and
/// input types, and will allocate a new offsets array if necessary (i.e. if
/// the offsets contain any nulls). If the offsets do not have nulls, they
- /// are assumed to be well-formed
+ /// are assumed to be well-formed.
+ ///
+ /// If a null_bitmap is not provided, the nulls will be inferred from the
+ /// offsets's null bitmap. But if a null_bitmap is provided, the offsets
array
+ /// can't have nulls.
+ ///
+ /// If a null_bitmap is provided, the offsets array can't be a slice (i.e. an
+ /// array with offset() > 0).
Review Comment:
It's an overlook. For some reason, my brain is having a really hard time
with these 4 slightly similar docstrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
