jonahgao commented on code in PR #7981:
URL: https://github.com/apache/arrow-datafusion/pull/7981#discussion_r1389315926
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -480,7 +488,8 @@ message Not {
message AliasNode {
LogicalExprNode expr = 1;
- string alias = 2;
+ repeated OwnedTableReference relation = 2;
+ string alias = 3;
Review Comment:
```suggestion
string alias = 2;
repeated OwnedTableReference relation = 3;
```
Reusing old tag numbers may be dangerous.
References:
- [Don’t Re-use a Tag
Number](https://protobuf.dev/programming-guides/dos-donts/#reuse-number)
- [Consequences of Reusing Field Numbers
](https://protobuf.dev/programming-guides/proto3/#consequences)
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -480,7 +488,8 @@ message Not {
message AliasNode {
LogicalExprNode expr = 1;
- string alias = 2;
+ repeated OwnedTableReference relation = 2;
+ string alias = 3;
Review Comment:
```suggestion
string alias = 2;
repeated OwnedTableReference relation = 3;
```
Reusing old tag numbers may be dangerous.
References:
- [Don’t Re-use a Tag
Number](https://protobuf.dev/programming-guides/dos-donts/#reuse-number)
- [Consequences of Reusing Field Numbers
](https://protobuf.dev/programming-guides/proto3/#consequences)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
