alamb commented on code in PR #7981:
URL: https://github.com/apache/arrow-datafusion/pull/7981#discussion_r1390389939
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -238,6 +238,16 @@ impl CommonSubexprEliminate {
let rewritten = pop_expr(&mut rewritten)?;
if affected_id.is_empty() {
+ // Alias aggregation expressions if they have changed
+ // TODO: This should be handled in `build_recover_project_plan`
once qualified aliases
Review Comment:
I think this comment is out of date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
