alamb opened a new pull request, #8127: URL: https://github.com/apache/arrow-datafusion/pull/8127
## Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/8043 ## Rationale for this change We encountered problem is our downstream tests that `RepartitionExec` was trying to preserve an order even when there is no order to preserve. This was because one codepath (`RepartitionExec::new_with_children`) it set the `preserve_order` flag to true when it creates a new `RepartitionExec` even if the new child had no order to preserve. During execution, this cause the code to try and merge a stream with no sort exprs, which causes an internal error ## What changes are included in this PR? 1. Update RepartitionExec::with_preserve_order to avoid 2. Improve documentation 3. add test ## Are these changes tested? Yes, though I am not thrilled with the test (I will comment inline) <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
