alamb commented on PR #8127: URL: https://github.com/apache/arrow-datafusion/pull/8127#issuecomment-1806797521
> Is it possible to move this test to the same file with struct RepartitionExec as a unit test? yes, that is a good idea -- I did so in ee55ec3d016574851aa2e77d0cf773990bc7aa32 > I also see one call with_preserve_order(false) which is unnecessary and confusing in enforce_distribution.rs as well as one such call in replace_with_order_preserving_variants.rs. Let's remove them. That is an excellent idea, I did so in 0c492e16fc7e0db5b17395559d878e8cd38caeba and I think the logic is much clearer now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
