Veeupup commented on PR #8140: URL: https://github.com/apache/arrow-datafusion/pull/8140#issuecomment-1807094157
> Thank you for this new function! Looks like these functions are available in DuckDB 👍🏼 https://duckdb.org/docs/sql/functions/nested.html#range-functions > > Here are some suggestions: > > 1. Can we add more corner case tests like `range(5,5,0), range(1,5,-1), range(1,-5,1)...` > 2. Include the semantics of this function (is start/end index inclusive or exclusive, what will happen for `range(1,5,-1)`) in SQL doc: https://github.com/apache/arrow-datafusion/blob/main/docs/source/user-guide/sql/scalar_functions.md thanks! I have made it clear in the test and doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
