alamb commented on code in PR #8140:
URL: https://github.com/apache/arrow-datafusion/pull/8140#discussion_r1391549901
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -579,6 +579,44 @@ pub fn array_pop_back(args: &[ArrayRef]) ->
Result<ArrayRef> {
)
}
+pub fn gen_range(args: &[ArrayRef]) -> Result<ArrayRef> {
Review Comment:
This is a very nice implementation 👨🍳 👌
Can you please add a docstring that explains that the arguments are and how
they are interpreted
Perhaps following the great example of @jayzhan211 in
https://github.com/apache/arrow-datafusion/blob/93a95775f51d21445958067b1da0991879464bb9/datafusion/physical-expr/src/array_expressions.rs#L582-L600
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -579,6 +579,44 @@ pub fn array_pop_back(args: &[ArrayRef]) ->
Result<ArrayRef> {
)
}
+pub fn gen_range(args: &[ArrayRef]) -> Result<ArrayRef> {
Review Comment:
This is a very nice implementation 👨🍳 👌
Can you please add a docstring that explains that the arguments are and how
they are interpreted
Perhaps following the great example of @jayzhan211 in
https://github.com/apache/arrow-datafusion/blob/93a95775f51d21445958067b1da0991879464bb9/datafusion/physical-expr/src/array_expressions.rs#L582-L600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
