alamb commented on code in PR #8093:
URL: https://github.com/apache/arrow-datafusion/pull/8093#discussion_r1390387818
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -1025,7 +1025,53 @@ pub fn to_substrait_rex(
col_ref_offset,
extension_info,
),
- _ => not_impl_err!("Unsupported expression: {expr:?}"),
+ Expr::IsNull(arg) => {
+ let arguments: Vec<FunctionArgument> = vec![FunctionArgument {
+ arg_type: Some(ArgType::Value(to_substrait_rex(
+ arg,
+ schema,
+ col_ref_offset,
+ extension_info,
+ )?)),
+ }];
+
+ let function_name = "is_null".to_string();
+ let function_anchor = _register_function(function_name,
extension_info);
Review Comment:
While reviewing the code again, I found this simply follows the same pattern
as the existing substrait code, so looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
