alamb commented on code in PR #8093:
URL: https://github.com/apache/arrow-datafusion/pull/8093#discussion_r1391204502
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -880,6 +886,42 @@ pub async fn from_substrait_rex(
ScalarFunctionType::ILike => {
make_datafusion_like(true, f, input_schema,
extensions).await
}
+ ScalarFunctionType::IsNull => {
+ let arg = f.arguments.first().ok_or_else(|| {
Review Comment:
Thank you @tgujar -- A follow on to make the argument checking handle too
many arguments would be most appreciated. Thank you 🙏
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -880,6 +886,42 @@ pub async fn from_substrait_rex(
ScalarFunctionType::ILike => {
make_datafusion_like(true, f, input_schema,
extensions).await
}
+ ScalarFunctionType::IsNull => {
+ let arg = f.arguments.first().ok_or_else(|| {
Review Comment:
Thank you @tgujar -- A follow on to make the argument checking handle too
many arguments would be most appreciated. Thank you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
