felipecrv commented on issue #36360: URL: https://github.com/apache/arrow/issues/36360#issuecomment-1810327874
> This is done by changing the internal functions to not define default_memory_pool() as the default argument and changing the callsites to explicitly pass the intended memory pool. Yes, of course. The bad consequence of this is that it breaks APIs that are already public. The multi-step approach I suggested in the description (temporary removal of the default + callsite fixes) would at least ensure the Arrow codebase itself is not using `default_memory_pool()` by accident. Eventually, we could break some of the APIs and drop the `pool = default_memory_pool()` from parameter declarations. I'm advocating we always pass `default_memory_pool()` explicitly in Arrow code even when a default value is defined in the declaration. That would make us better judge how annoying being explicit becomes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
