ShaiviAgarwal2 commented on issue #36360: URL: https://github.com/apache/arrow/issues/36360#issuecomment-1811694640
@felipecrv Could you please check whether I'm understanding it correctly or not!! To enhance the code, we need to modify the internal functions to not define `default_memory_pool()` as a default argument and change the callsites to pass a memory pool they receive from callers or explicitly pass the `default_memory_pool()`. Then we need to change the declarations of functions that call `default_memory_pool()` to take a `MemoryPool * `parameter instead. Finally, we should always pass `default_memory_pool()` explicitly in the Arrow code even when a default value is defined in the declaration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
