benibus commented on code in PR #36073:
URL: https://github.com/apache/arrow/pull/36073#discussion_r1392926120
##########
cpp/src/parquet/arrow/test_util.h:
##########
@@ -65,12 +66,30 @@ struct Decimal256WithPrecisionAndScale {
static constexpr int32_t scale = PRECISION - 1;
};
+inline void RandomHalfFloatValues(int64_t n, uint32_t seed,
Review Comment:
We could either create a corresponding `parquet/arrow/test_util.cc` or put
it in `parquet/test_util.cc`. I'm not sure if the former is worth doing in this
case, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
