benibus commented on PR #36073: URL: https://github.com/apache/arrow/pull/36073#issuecomment-1811253615
Update: I don't think it'd be very useful to add tests for different type lengths at the reader/writer level since it isn't even possible to construct a `PrimitiveNode` with an inapplicable length without throwing an exception. I suppose that's why there aren't similar test for other (e.g. decimal, uuid) types AFAICT. However, it turns out that I forgot to add the relevant tests to `schema_test.cc`, so I went ahead and included those - along with the other requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
