joellubi commented on code in PR #1304:
URL: https://github.com/apache/arrow-adbc/pull/1304#discussion_r1395547000
##########
go/adbc/drivermgr/wrapper_sqlite_test.go:
##########
@@ -334,6 +334,85 @@ func (dm *DriverMgrSuite) TestGetObjectsTableType() {
dm.False(rdr.Next())
}
+func (dm *DriverMgrSuite) TestGetTableSchema() {
+ schema, err := dm.conn.GetTableSchema(dm.ctx, nil, nil, "test_table")
+ dm.NoError(err)
+
+ expSchema := arrow.NewSchema(
+ []arrow.Field{
+ {Name: "id", Type: arrow.PrimitiveTypes.Int64,
Nullable: true},
+ {Name: "name", Type: arrow.PrimitiveTypes.Int64,
Nullable: true}, // Should be arrow.BinaryTypes.String
Review Comment:
I would have expected the SQLite type `TEXT` to map to
`arrow.BinaryTypes.String`. I've confirmed via the SQLite driver separately
(see screenshot) that this is in fact the behavior of the current driver
implementation, so this test actually does indicate the correct behavior for
the CGO wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
