joellubi commented on code in PR #1304:
URL: https://github.com/apache/arrow-adbc/pull/1304#discussion_r1395680698
##########
go/adbc/drivermgr/wrapper_sqlite_test.go:
##########
@@ -334,6 +334,85 @@ func (dm *DriverMgrSuite) TestGetObjectsTableType() {
dm.False(rdr.Next())
}
+func (dm *DriverMgrSuite) TestGetTableSchema() {
+ schema, err := dm.conn.GetTableSchema(dm.ctx, nil, nil, "test_table")
+ dm.NoError(err)
+
+ expSchema := arrow.NewSchema(
+ []arrow.Field{
+ {Name: "id", Type: arrow.PrimitiveTypes.Int64,
Nullable: true},
+ {Name: "name", Type: arrow.PrimitiveTypes.Int64,
Nullable: true}, // Should be arrow.BinaryTypes.String
Review Comment:
Thanks @lidavidm, I didn't realize that. This now works as expected after
inserting test data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
