metesynnada commented on PR #8234: URL: https://github.com/apache/arrow-datafusion/pull/8234#issuecomment-1818804440
> Thank you @metesynnada -- this looks like a nice refactoring to me. I had some suggestions on documentation and API design but I think they could also be done as follow on PRs > > I had some questions: > > 1. Do you plan to add new join implementations to DataFusion, and if so are your plans written anywhere? A trait is a nice way to keep specialized implementation in other crates as well. > 2. Is it possible to extend "eager join" to MergeJoin? Would that even be a good idea? > 3. I don't understand how always reading alternately from left and right inputs would work (I left a more detailed question / comment below) 1. While we have additional joins planned for our roadmap, we haven't announced these publicly yet. 2. Thank you for the suggestion – it's a great idea! 3. To reiterate, our current implementation of streaming joins is just the beginning. The polling mechanism you see now is foundational, serving as a template for more advanced features and enhancements we plan to introduce moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
