alamb commented on code in PR #8234:
URL: https://github.com/apache/arrow-datafusion/pull/8234#discussion_r1399289855
##########
datafusion/physical-plan/src/joins/stream_join_utils.rs:
##########
@@ -669,9 +718,44 @@ pub enum EagerJoinStreamState {
BothExhausted { final_result: bool },
}
-/// Represents the asynchronous trait for an eager join stream.
-/// This trait defines the core methods for handling asynchronous join
operations
-/// between two streams (left and right).
+/// `EagerJoinStream` is an asynchronous trait designed for managing
incremental join operations
Review Comment:
👍
##########
datafusion/physical-plan/src/joins/stream_join_utils.rs:
##########
@@ -669,9 +718,44 @@ pub enum EagerJoinStreamState {
BothExhausted { final_result: bool },
}
-/// Represents the asynchronous trait for an eager join stream.
-/// This trait defines the core methods for handling asynchronous join
operations
-/// between two streams (left and right).
+/// `EagerJoinStream` is an asynchronous trait designed for managing
incremental join operations
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
