alamb commented on issue #7698: URL: https://github.com/apache/arrow-datafusion/issues/7698#issuecomment-1819193443
> LogicalPlan (and maybe other modules) does the same operation over and over again without any precomputing or caching in a single planning session. And LogicalPlan cannot cache anything and match each time it is called since it is an enum. In my opinion, it would be better to make it a trait and each concrete plan node implements the trait. I think there are tradeoffs of each approach for sure. We have had some discussions about the various pros and cons in the past that might interest you: * https://github.com/apache/arrow-datafusion/issues/3651 * https://github.com/apache/arrow-datafusion/issues/2175 > It's just my humble opinion. (I don't have deep knowledge of plan building) In general, I think you have identified the core improvements necessary to support faster planning with complex schemas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
