jayzhan211 commented on code in PR #8269:
URL: https://github.com/apache/arrow-datafusion/pull/8269#discussion_r1399906000
##########
datafusion/sql/src/expr/value.rs:
##########
@@ -138,9 +138,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
schema,
&mut PlannerContext::new(),
)?;
+
match value {
Expr::Literal(scalar) => {
- values.push(scalar);
+ values.push(Expr::Literal(scalar));
+ }
+ Expr::ScalarFunction(ref scalar_function) => {
+ if scalar_function.fun == BuiltinScalarFunction::MakeArray
{
+
values.push(Expr::ScalarFunction(scalar_function.clone()));
Review Comment:
May we consider `values.push(value)` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
