Veeupup commented on code in PR #8269:
URL: https://github.com/apache/arrow-datafusion/pull/8269#discussion_r1401992587
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -228,10 +228,10 @@ fn compute_array_dims(arr: Option<ArrayRef>) ->
Result<Option<Vec<Option<u64>>>>
fn check_datatypes(name: &str, args: &[&ArrayRef]) -> Result<()> {
let data_type = args[0].data_type();
- if !args
- .iter()
- .all(|arg| arg.data_type().equals_datatype(data_type))
- {
+ if !args.iter().all(|arg| {
+ arg.data_type().equals_datatype(data_type)
+ || arg.data_type().equals_datatype(&DataType::Null)
Review Comment:
when it comes to handle multi arrays functions,their input types maybe like
`null, List(Int32)...`. Then, but we should handle `null` type in function body
rather than return error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
