jhorstmann commented on code in PR #5100:
URL: https://github.com/apache/arrow-rs/pull/5100#discussion_r1401198685
##########
arrow-array/src/arithmetic.rs:
##########
@@ -45,6 +45,19 @@ pub trait ArrowNativeTypeOp: ArrowNativeType {
/// The multiplicative identity
const ONE: Self;
+ /// The minimum value and identity for the `max` aggregation.
+ /// Note that the aggregation uses the total order predicate for floating
point values,
+ /// which means that this value is a negative NaN.
+ const MIN: Self;
+
+ /// The maximum value and identity for the `min` aggregation.
+ /// Note that the aggregation uses the total order predicate for floating
point values,
+ /// which means that this value is a positive NaN.
+ const MAX: Self;
+
+ /// The number of bytes occupied by this type
Review Comment:
yes, removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
