tustvold commented on code in PR #5100:
URL: https://github.com/apache/arrow-rs/pull/5100#discussion_r1401237238
##########
arrow-array/src/arithmetic.rs:
##########
@@ -377,9 +437,16 @@ macro_rules! native_type_float_op {
};
}
-native_type_float_op!(f16, f16::ZERO, f16::ONE);
-native_type_float_op!(f32, 0., 1.);
-native_type_float_op!(f64, 0., 1.);
+native_type_float_op!(
+ f16,
+ f16::ZERO,
+ f16::ONE,
+ f16::from_bits(f16::NAN.to_bits() ^ 0x8000),
+ f16::NAN,
+ u16
+);
+native_type_float_op!(f32, 0., 1., -f32::NAN, f32::NAN, u32);
Review Comment:
> in the group by implementation of datafusion, would they be considered as
separate groups
They would be treated as separate groups, yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
