alamb commented on code in PR #8291:
URL: https://github.com/apache/arrow-datafusion/pull/8291#discussion_r1401942608
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -973,6 +982,24 @@ fn create_schema(
Ok(Schema::new(fields))
}
+/// returns schema with dictionary group keys materialized as their value types
+/// The actual convertion happens in `RowConverter` and we don't do unnecessary
+/// conversion back into dictionaries
+fn materialize_dict_group_keys(schema: &Schema, group_count: usize) -> Schema {
Review Comment:
`GroupValues` is a trait and there are two implementations of it --
`GroupValueRows` and `GroupValuesPrimitive`
This conversion only applies to `GroupValueRows` (though
`GroupValuesPrimitive` won't be used for input dictionary columns anyways)
I wonder if there is some way to move the conversion into `GroupValueRows`
so it is clearer from the context when this is needed or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
