alamb commented on PR #8291: URL: https://github.com/apache/arrow-datafusion/pull/8291#issuecomment-1834633668
> @alamb I think the following test looks to be enough: > > ``` > query T > select arrow_typeof(x_dict) from value_dict group by x_dict; > ---- > Int32 > Int32 > Int32 > Int32 > Int32 > ``` > > Adding schemas into `EXPLAIN` seems to be a bit of an overkill at least if we have only this case where it could be useful. Sorry for the late reply @qrilka -- what I was thinking is "if someone undid this code change, would any of the tests fail to know we broke it" I think the answer is no. So that is what I was thinking about the test. I am not sure if you are proposing a new test or saying an existing test is sufficient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
